propagate parent tag context downward to improve runtime #191
+84
−73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrispy-snps
force-pushed
the
chrispy/propagate-contexts-downward
branch
from
a5b09f1 to
b48c482
Compare
chrispy-snps
changed the title
chrispy-snps
force-pushed
the
chrispy/propagate-contexts-downward
branch
from
b48c482 to
f9efec0
Compare
Signed-off-by: chrispy <chrispy@synopsys.com>
chrispy-snps
force-pushed
the
chrispy/propagate-contexts-downward
branch
from
f9efec0 to
9848a04
Compare
|
Ah, one last thing: the readme examples for the custom converters still have the |
chrispy-snps
force-pushed
the
chrispy/propagate-contexts-downward
branch
from
caf0ec9 to
02a2bca
Compare
Signed-off-by: Chris Papademetrious <chrispy@synopsys.com>
|
@AlexVonB - good catch on the README.rst file, thank you! This pull request improves runtime for hierarchically deep HTML structures (as opposed to #186, which improves runtime for broad flat HTML structures). @AlexVonB , @AlextheYounga - this branch now includes #186. I did some local correctness and performance testing, but I would appreciate any additional testing you can provide so we can merge this in confidence. |
|
@AlexVonB, @AlextheYounga - I had one more look through the code and felt pretty good about it, so I merged it. |
Wuhall
pushed a commit
to Wuhall/python-markdownify
that referenced
this pull request
May 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #190.
Improves runtime by propagating the parent tag context downward into children. Python
set()objects are used because membership tests are fast and deduplication is automatic.In addition, the following "pseudo-parent" parent tag names are propagated:
_inline- parent include a heading,td, orthtag_noformat- parents include apre,code,kbd, orsamptagFor one of my large HTML testcases that has
<div>,<article>, and<section>hierarchy, runtime improves from 502 seconds to 261 seconds.This pull request changes the interface for
convert_*()functions by changing theconvert_as_inlineBoolean parameter to aparent_tagsset parameter, so this change should probably be made in a major version number change.